test[next]: Disable iterator tests on DaCe GTIR backend #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Why is main green before this change? |
Because there are 4 DaCe backends: The old DaCe ITIR backend was also enabled in |
havogt
approved these changes
Dec 4, 2024
philip-paul-mueller
added a commit
that referenced
this pull request
Dec 4, 2024
The [initial version](#1594) of the optimization pipeline only contained a rough draft. Currently this PR contains a copy of the map fusion transformations from DaCe that are currently under [review](spcl/dace#1629). As soon as that PR is merged and DaCe was updated in GT4Py these files will be deleted. This PR collects some general improvements: - [x] More liberal `LoopBlocking` transformation (with tests). - [x] Incorporate `MapFusionParallel` - [x] Using of `can_be_applied_to()` as soon as DaCe is updated (`TrivialGPUMapElimination`, `SerialMapPromoter`). - [x] Looking at strides that the Lowering generates. (Partly done) However, it still uses MapFusion implementation that ships with GT4Py and not the one in DaCe. Note: Because of commit 60e4226 this PR must be merged after [PR1768](#1768).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 places where the
program_processorfixture used in tests is configured:and there are four DaCe backends:
The
DACE_CPUandDACE_GPUbackends will be the default backends, that also apply the DaCe optimization pipeline. However, these backends are disabled for now because we are awaiting #1639.The
DACE_CPU_NO_OPTandDACE_GPU_NO_OPTapply the lowering to SDFG but do not run the optimization pipeline. These backends are currently enabled in GT4Py tests.However, we observed failures in some iterator tests controlled by the
program_processorfixture intests/next_tests/unit_tests/conftest.py, onceDACE_CPUis enabled. In this PR, we are disabling such tests: we will address these issues in a separate PR.